Skip to content

Conversation

@kkwli
Copy link
Collaborator

@kkwli kkwli commented Dec 3, 2025

No description provided.

@kkwli kkwli self-assigned this Dec 3, 2025
@Meinersbur
Copy link
Member

Linking an executable requires libflang_rt.runtime.a/so, so the test would fail if it is not present. Did I forget to define "flang-rt" in lit.site.py if LLVM_ENABLE_RUNTIMES=flang-rt?

@kkwli
Copy link
Collaborator Author

kkwli commented Dec 3, 2025

Linking an executable requires libflang_rt.runtime.a/so, so the test would fail if it is not present. Did I forget to define "flang-rt" in lit.site.py if LLVM_ENABLE_RUNTIMES=flang-rt?

My understanding is that this test is in flang-rt and is part of check-flang-rt. I assume that the libflang_rt.runtime.a/so would have been successfully built before doing check-flang-rt.

I don't see config.available_features.add("flang-rt") in flang-rt/test/lit.cfg.py.

Copy link
Member

@Meinersbur Meinersbur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. When I added REQUIRES: flang-rt, the file was still in flang/.

@kkwli kkwli merged commit 3402391 into llvm:main Dec 4, 2025
11 checks passed
kcloudy0717 pushed a commit to kcloudy0717/llvm-project that referenced this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants